Merge Request #11

Merged
jerasure/gf-complete!11
Created by Loic Dachary

convert manual from PDF to HTML

Assignee: None
Milestone: None
Checking for CI status for 547f67ec

Merged by KMG

Commits (1)
3 participants
  • Chuck
    KMG @kmg
    Choose File ...   File name...
    Cancel
  • Loic avatar small 75dpi
    Loic Dachary @dachary

    thanks !

    Choose File ...   File name...
    Cancel
  • Eec633b4322a1884e5bd1861f08b6112?s=40&d=identicon
    Nyan @Nyan (Edited )

    Could we keep a copy of the original PDF as well? There's a number of conversion mistakes with the HTML version, mostly aesthetics, but can cause confusion.

    I've fixed what I've noticed here, but I expect there to be more mistakes. Keeping a PDF version at least serves as a reference to what the manual is supposed to be, until someone's gone through and fixed all the mistakes.

    Choose File ...   File name...
    Cancel
  • Loic avatar small 75dpi
    Loic Dachary @dachary

    Hi,

    You should be able to find the PDF in the git history. The fixes you did look great, could you make a merge request out of them so they can be merged ?

    Cheers

    Choose File ...   File name...
    Cancel
  • Eec633b4322a1884e5bd1861f08b6112?s=40&d=identicon
    Nyan @Nyan

    I'm not sure if everyone clones the git repo, much less know about the existence of the PDF. Since it's online though, perhaps a link in the HTML should do, until it all gets fixed?

    How do you create merge requests here? I can't seem to find any button to do so.
    Also, is the merge based of a whole branch or just a commit? If the former, is it possible to cherry pick the commit?

    Choose File ...   File name...
    Cancel
  • Chuck
    KMG @kmg (Edited )

    @Nyan Go here: http://lab.jerasure.org/jerasure/gf-complete/merge_requests

    There should be a button to create using "New Merge Request"

    Choose File ...   File name...
    Cancel
  • Eec633b4322a1884e5bd1861f08b6112?s=40&d=identicon
    Nyan @Nyan

    Thanks for the reply. Perhaps I lack permissions or something? This is what I see:

    Choose File ...   File name...
    Cancel
  • Chuck
    KMG @kmg

    @Nyan Added you as a 'developer,' so it should work now :)

    Choose File ...   File name...
    Cancel
  • Eec633b4322a1884e5bd1861f08b6112?s=40&d=identicon
    Nyan @Nyan

    Thank you @KMG merge request submitted :)

    By the way, unrelated, but if I have the right person, I believe I sent you an email over a week ago, regarding GF-Complete, but didn't get a response. Would you happen to have not received it?

    Choose File ...   File name...
    Cancel
  • Chuck
    KMG @kmg

    @Nyan Yeah, I am the guy... Just ridiculously busy. Don't worry, I'll get back to that thread in a week or so.

    Choose File ...   File name...
    Cancel
  • Eec633b4322a1884e5bd1861f08b6112?s=40&d=identicon
    Nyan @Nyan

    No worries - totally understand that. Thanks for the reply.

    Choose File ...   File name...
    Cancel