Issue #2

0 up
0 down
Closed
jerasure/gf-complete#2
Created by Loic Dachary (Edited )

ARMv7 : gf_unit 16 A -1 -m SPLIT 16 4 -r ALTMAP -

gf_unit 16 A -1 -m SPLIT 16 4 -r ALTMAP -
Args: 16 A -1 -m SPLIT 16 4 -r ALTMAP - / size (bytes): 524428
Problem with region multiply (all values in hex):
   Target address base: 0x8fd08e.  Word 0x1 of 0x1fee.  Xor: 0
   Value: 2
   Original source word: d00a
   Product word: a000
   It should be: b01f

related ceph-devel thread http://thread.gmane.org/gmane.comp.file-systems.ceph.devel/22636

Assignee: None
Milestone: None
3 participants
  • 3bd79d22d1246850e00b0d6f770253fe?s=40&d=identicon
    bassamtabbara @bassamtabbara

    We see this too on a cortex-a15 in qemu

    FAIL: gf_unit_w16
    =================
    
    Args: 16 A -1 - / size (bytes): 524428
    Args: 16 A -1 -m SHIFT - / size (bytes): 72
    Args: 16 A -1 -m GROUP 4 4 - / size (bytes): 200
    Args: 16 A -1 -m BYTWO_p - / size (bytes): 96
    Args: 16 A -1 -m BYTWO_p -r NOSIMD - / size (bytes): 96
    Args: 16 A -1 -m BYTWO_b - / size (bytes): 96
    Args: 16 A -1 -m BYTWO_b -r NOSIMD - / size (bytes): 96
    Args: 16 A -1 -m TABLE - / size (bytes): 655500
    Args: 16 A -1 -m LOG - / size (bytes): 524428
    Args: 16 A -1 -m LOG_ZERO - / size (bytes): 917644
    Args: 16 A -1 -m SPLIT 16 4 - / size (bytes): 524428
    Args: 16 A -1 -m SPLIT 16 4 -r SIMD - / size (bytes): 524428
    Args: 16 A -1 -m SPLIT 16 4 -r NOSIMD - / size (bytes): 524428
    Problem with region multiply (all values in hex):
       Target address base: 0x5e709e.  Word 0x1 of 0x1fdb.  Xor: 0
       Value: 2
       Original source word: 2dab
       Product word: 5a0b
       It should be: 5b56
    lt-gf_unit: gf_general.c:315: gf_general_do_region_check: Assertion `0' failed.
    Args: 16 A -1 -m SPLIT 16 4 -r ALTMAP - / size (bytes): 524428
    ./gf_unit_w16.sh: line 14:  8636 Aborted                 (core dumped) ../test/gf_unit 16 A -1 -m SPLIT 16 4 -r ALTMAP -
    FAIL gf_unit_w16.sh (exit status: 134)
    
    Choose File ...   File name...
    Cancel
  • Eec633b4322a1884e5bd1861f08b6112?s=40&d=identicon
    Nyan @Nyan

    Would you be able to give this change a try? http://jerasure.org/jerasure/gf-complete/merge_requests/16

    Choose File ...   File name...
    Cancel
  • 3bd79d22d1246850e00b0d6f770253fe?s=40&d=identicon
    bassamtabbara @bassamtabbara

    Yes, I'll try it out and get back to you. Thanks for the quick response.

    Choose File ...   File name...
    Cancel
  • 3bd79d22d1246850e00b0d6f770253fe?s=40&d=identicon
    bassamtabbara @bassamtabbara

    I applied your changes to gf.c and gf_w16_neon.c only, and it seems to have fixed the test:

    ===========================================
       gf-complete 1.0: tools/test-suite.log
    ===========================================
    
    # TOTAL: 6
    # PASS:  6
    # SKIP:  0
    # XFAIL: 0
    # FAIL:  0
    # XPASS: 0
    # ERROR: 0
    
    .. contents:: :depth: 2
    
    
    Choose File ...   File name...
    Cancel
  • Eec633b4322a1884e5bd1861f08b6112?s=40&d=identicon
    Nyan @Nyan

    Thanks for the confirmation!

    Choose File ...   File name...
    Cancel
  • Loic avatar small 75dpi
    Loic Dachary @dachary

    Status changed to closed by commit 51a1abb9185ec6ea35817620d13322047f4fde4d

    Choose File ...   File name...
    Cancel