Commit 9fbc44259355b00d1271c21bf14493d039160ccf

Authored by Kefu Chai
1 parent a6847973
Exists in master

gf_w32.c: silence the -Wmaybe-uninitialized warning

in gf_w32_cfmgk_multiply_region_from_single(), follow warning is
reported by gcc:

gf-complete/src/gf_w32.c:410:5: warning: ‘a’ may be used uninitialized
in this function [-Wmaybe-uninitialized]
   g = _mm_insert_epi64 (a, g_star, 0);
     ^

actually, we are using `a` as a dummy parameter for initializing `g` and
`q`. and only the lower lower 64 bits of them are used when doing
calculation. but their lower 64 bits are always initialized using
_mm_insert_epi64(). so this is a false alarm.

but we can silence this warning by moving the statement initializing `a`
up before passing it to  _mm_insert_epi64(). this change does not hurt
the performance.

Signed-off-by: Kefu Chai <kchai@redhat.com>
Showing 1 changed file with 1 additions and 1 deletions   Show diff stats
src/gf_w32.c
... ... @@ -407,9 +407,9 @@ gf_w32_cfmgk_multiply_region_from_single(gf_t *gf, void *src, void *dest, uint32
407 407 q_plus = *(uint64_t *) h->private;
408 408 g_star = *((uint64_t *) h->private + 1);
409 409  
  410 + a = _mm_insert_epi32 (_mm_setzero_si128(), val, 0);
410 411 g = _mm_insert_epi64 (a, g_star, 0);
411 412 q = _mm_insert_epi64 (a, q_plus, 0);
412   - a = _mm_insert_epi32 (_mm_setzero_si128(), val, 0);
413 413 s32 = (uint32_t *) src;
414 414 d32 = (uint32_t *) dest;
415 415  
... ...